583548 - Performance regression with animations (choppy)

Status: RESOLVED WORKSFORME

(Core :: Layout, defect)

Description

[IU]

User-Agent:       Mozilla/5.0 (Windows; Windows NT 5.1; rv:2.0b3pre) Gecko/20100730 Minefield/4.0b3pre (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; Windows NT 5.1; rv:2.0b3pre) Gecko/20100730 Minefield/4.0b3pre

There's a drawing regression a user reported on mozillazine.org.  I highly suspect this is more retained layers fallout.

Regression window:

Smooth:
Mozilla/5.0 (Windows; Windows NT 5.1; en-US; rv:2.0b2pre) Gecko/20100715 Minefield/4.0b2pre

Choppy:
Mozilla/5.0 (Windows; Windows NT 5.1; en-US; rv:2.0b2pre) Gecko/20100716 Minefield/4.0b2pre

Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=5fda39cd703c&tochange=96de199027d7

There were a lot of checkins that day -- including numerous retained layers patches.

Here is a list of additional sites the original reporter said also illustrate the issues.  I have not tested them myself, so YMMV:

http://www.myjquery.co.uk/docs/x1/demos ... e_demo.php
http://www.myjquery.co.uk/docs/x1/demos/coda_bubble_demo.php
http://www.dynamicdrive.com/dynamicindex5/stickytooltip.htm
http://www.serie3.info/s3slider/demonstration.html
http://cssglobe.com/lab/tooltip/01/
http://nettuts.s3.amazonaws.com/234_tooltip/Demo/index.html
http://www.queness.com/resources/html/tooltip/jquery-tooltip-queness.html


Reproducible: Always

Steps to Reproduce:
1. Load linked URL: http://www.moreira.ch/
2. Hover your mouse in any of the following regions and observer that the popups are animated in two steps -- instead of smoothly as they should be:
a) between the "moreira" large print and the box
b) anywhere on the box
c) below the box, on the "Contact" button
d) on the icons or word at the very bottom
3. Compare this with either the non-regressed build or with competing browsers.

Note: This issue should be easily observable; however, if you have trouble observing the regression, down-clock your system.  With a laptop, that should be as easy as unplugging its power cord.

Comment 1

[(mostly gone) XtC4UaLL [:xtc4uall]]

(In reply to comment #0)
> There's a drawing regression a user reported on mozillazine.org.  I highly
> suspect this is more retained layers fallout.
> 
> There were a lot of checkins that day -- including numerous retained layers
> patches.

I verified it's caused by the Checkins for Bug 564991 by testing with my saved Hourly Builds, thus the Range is:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=92339b84d089&tochange=e1d7fd5255fd

Comment 2

[Alice0775 White]

Attachment: reduced testcase

Comment 3

[Ryan VanderMeulen [:RyanVM]]

I'm betting this is related to bug 578785 & bug 579323.

Comment 4

[IU]

Bug 579323 does not fix this.  What now?

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Fixed by http://hg.mozilla.org/mozilla-central/rev/1f08cbe27e32 maybe?

Comment 6

[IU]

(In reply to comment #5)
> Fixed by http://hg.mozilla.org/mozilla-central/rev/1f08cbe27e32 maybe?

With hardware acceleration turned off: it's improved, but not quite there yet.  There's still a slight regression.  You can still see the 2-stepping during initial animation.  Subsequent animation is smooth but then it will occasionally 2-step.

With hardware acceleration turned on: it's smooth (with lots of artifacts, on my system); thus, I'm not going to mark this resolved on account of hardware acceleration making it smooth, as I occasionally have to turn it off to make things work properly.  See: https://bugzilla.mozilla.org/show_bug.cgi?id=593600 and https://bugzilla.mozilla.org/show_bug.cgi?id=593609

Comment 7

[Dan]

Not sure if this is the same issue here: http://www.microsoft.com/windows/windows-7/compare/pc-vs-mac.aspx.  Click on any of the buttons below the image ("having fun", "simplicity", "working hard").  The image that slides down leaves a trail.  Happens for me even w/ hardware acceleration on in FF4 b5.  Happens both in Mac and on Windows.  I don't see it in any other browser that I have tried (IE, Chrome, Safari).

Comment 8

[IU]

No longer seeing this, though I don't know what fixed it. Hardware acceleration disabled.

Mozilla/5.0 (Windows NT 5.1; rv:2.0b7pre) Gecko/20100915 Firefox/4.0b7pre ID:20100915073756